Fix error when tsconfig.json contains comment #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypresto
force-pushed
the
fix-comment-json
branch
from
fd2be90
to
6cb6a97
Compare
|
can we get this merged in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(e || "").replace is not a functionUnhandledPromiseRejectionWarning: TypeError: (e || "").replace is not a function #21, it is because catch (e) { setFailed(e) } passes Error object tosetFailed(message: string)(e is any in TS)ts.readConfigFile()instead offs.readFileSync()(Supports JSON files with comments #9 solves same error but this PR uses builtin function from TS library and does not add any deps.